Skip to content

Commit a963c01

Browse files
committed
Cleanup
1 parent 3775044 commit a963c01

File tree

5 files changed

+12
-105
lines changed

5 files changed

+12
-105
lines changed

Detectors/TPC/calibration/CMakeLists.txt

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@ o2_add_library(TPCCalibration
2525
src/CalibPadGainTracksBase.cxx
2626
src/CalibLaserTracks.cxx
2727
src/LaserTracksCalibrator.cxx
28-
src/NeuralNetworkClusterizer.cxx
2928
src/SACDecoder.cxx
3029
src/IDCAverageGroup.cxx
3130
src/IDCAverageGroupBase.cxx
@@ -84,7 +83,6 @@ o2_target_root_dictionary(TPCCalibration
8483
include/TPCCalibration/FastHisto.h
8584
include/TPCCalibration/CalibLaserTracks.h
8685
include/TPCCalibration/LaserTracksCalibrator.h
87-
include/TPCCalibration/NeuralNetworkClusterizer.h
8886
include/TPCCalibration/SACDecoder.h
8987
include/TPCCalibration/IDCAverageGroup.h
9088
include/TPCCalibration/IDCAverageGroupBase.h

Detectors/TPC/calibration/include/TPCCalibration/NeuralNetworkClusterizer.h

Lines changed: 0 additions & 38 deletions
This file was deleted.

Detectors/TPC/calibration/src/NeuralNetworkClusterizer.cxx

Lines changed: 0 additions & 50 deletions
This file was deleted.

GPU/GPUTracking/TPCClusterFinder/GPUTPCNNClusterizerHost.cxx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ void GPUTPCNNClusterizerHost::init(const GPUSettingsProcessingNNclusterizer& set
3636
std::vector<std::string> evalMode = o2::utils::Str::tokenize(settings.nnEvalMode, ':');
3737

3838
if (settings.nnLoadFromCCDB) {
39-
reg_model_path = settings.nnLocalFolder + "/net_regression_c1.onnx"; // Needs to be set identical to NeuralNetworkClusterizer.cxx, otherwise the networks might be loaded from the wrong place
39+
reg_model_path = settings.nnLocalFolder + "/net_regression_c1.onnx"; // Needs to be set identical to GPUWorkflowSpec.cxx, otherwise the networks might be loaded from the wrong place
4040
if (evalMode[0] == "c1") {
4141
class_model_path = settings.nnLocalFolder + "/net_classification_c1.onnx";
4242
} else if (evalMode[0] == "c2") {

GPU/Workflow/src/GPUWorkflowSpec.cxx

Lines changed: 11 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,6 @@
7878
#include "DetectorsRaw/RDHUtils.h"
7979
#include "ITStracking/TrackingInterface.h"
8080
#include "GPUWorkflowInternal.h"
81-
#include "TPCCalibration/NeuralNetworkClusterizer.h"
8281
// #include "Framework/ThreadPool.h"
8382

8483
#include <TStopwatch.h>
@@ -804,15 +803,13 @@ void GPURecoWorkflowSpec::run(ProcessingContext& pc)
804803
size_t size = DataRefUtils::getPayloadSize(m);
805804
if (nnClusterizerSettings.nnCCDBDumpToFile == 1) {
806805
dumpOnnxToFile(buffer, size, "net_classification_c1.onnx");
807-
LOG(info) << "(NN CLUS) Dumped nn_classification_c1 from CCDB to net_classification_c1.onnx";
808806
}
809807
} else if (evalMode[0] == "c2") {
810808
m = pc.inputs().get("nn_classification_c2");
811809
const char* buffer = const_cast<char*>(m.payload);
812810
size_t size = DataRefUtils::getPayloadSize(m);
813811
if (nnClusterizerSettings.nnCCDBDumpToFile == 1) {
814812
dumpOnnxToFile(buffer, size, "net_classification_c2.onnx");
815-
LOG(info) << "(NN CLUS) Dumped nn_classification_c2 from CCDB to net_classification_c2.onnx";
816813
}
817814
}
818815

@@ -821,15 +818,13 @@ void GPURecoWorkflowSpec::run(ProcessingContext& pc)
821818
size_t size = DataRefUtils::getPayloadSize(m);
822819
if (nnClusterizerSettings.nnCCDBDumpToFile == 1) {
823820
dumpOnnxToFile(buffer, size, "net_regression_c1.onnx");
824-
LOG(info) << "(NN CLUS) Dumped nn_regression_c1 from CCDB to net_regression_c1.onnx";
825821
}
826822
if (evalMode[1] == "r2") {
827823
m = pc.inputs().get("nn_regression_c2");
828824
const char* buffer = const_cast<char*>(m.payload);
829825
size_t size = DataRefUtils::getPayloadSize(m);
830826
if (nnClusterizerSettings.nnCCDBDumpToFile == 1) {
831827
dumpOnnxToFile(buffer, size, "net_regression_c2.onnx");
832-
LOG(info) << "(NN CLUS) Dumped nn_regression_c2 from CCDB to net_regression_c2.onnx";
833828
}
834829
}
835830
}
@@ -1292,9 +1287,9 @@ Inputs GPURecoWorkflowSpec::inputs()
12921287
std::map<std::string, std::string> metadata;
12931288
metadata["inputDType"] = nnClusterizerSettings.nnInferenceInputDType; // FP16 or FP32
12941289
metadata["outputDType"] = nnClusterizerSettings.nnInferenceOutputDType; // FP16 or FP32
1295-
metadata["nnCCDBWithMomentum"] = nnClusterizerSettings.nnCCDBWithMomentum; // 0, 1 -> Only for regression model
1290+
metadata["nnCCDBWithMomentum"] = nnClusterizerSettings.nnCCDBWithMomentum; // 0, 1 -> Only for regression model
12961291
metadata["nnCCDBLayerType"] = nnClusterizerSettings.nnCCDBClassificationLayerType; // FC, CNN
1297-
metadata["nnCCDBInteractionRate"] = nnClusterizerSettings.nnCCDBInteractionRate; // in kHz
1292+
metadata["nnCCDBInteractionRate"] = nnClusterizerSettings.nnCCDBInteractionRate; // in kHz
12981293
metadata["nnCCDBBeamType"] = nnClusterizerSettings.nnCCDBBeamType; // pp, pPb, PbPb
12991294

13001295
auto convert_map_to_metadata = [](const std::map<std::string, std::string>& inputMap, std::vector<o2::framework::CCDBMetadata>& outputMetadata) {
@@ -1308,13 +1303,15 @@ Inputs GPURecoWorkflowSpec::inputs()
13081303
std::vector<std::string> evalMode = o2::utils::Str::tokenize(nnClusterizerSettings.nnEvalMode, ':');
13091304
std::vector<o2::framework::CCDBMetadata> ccdb_metadata;
13101305

1311-
auto printSettings = [](const std::map<std::string, std::string>& settings) {
1312-
LOG(info) << "(NN CLUS) NN Clusterizer CCDB settings:";
1313-
for (const auto& [key, value] : settings) {
1314-
LOG(info) << " " << key << " : " << value;
1315-
}
1316-
};
1317-
printSettings(metadata);
1306+
if (mConfParam->printSettings) {
1307+
auto printSettings = [](const std::map<std::string, std::string>& settings) {
1308+
LOG(info) << "(NN CLUS) NN Clusterizer CCDB settings:";
1309+
for (const auto& [key, value] : settings) {
1310+
LOG(info) << " " << key << " : " << value;
1311+
}
1312+
};
1313+
printSettings(metadata);
1314+
}
13181315

13191316
if (evalMode[0] == "c1") {
13201317
metadata["nnCCDBEvalType"] = "classification_c1";

0 commit comments

Comments
 (0)