GPU TPC CF: Fix rounding error in qMax cut

davidrohr · davidrohr · commit 978eb74bff6a · 2025-03-17T09:23:17.000+01:00
diff --git a/GPU/GPUTracking/TPCClusterFinder/ClusterAccumulator.cxx b/GPU/GPUTracking/TPCClusterFinder/ClusterAccumulator.cxx
@@ -98,10 +98,7 @@ GPUd() bool ClusterAccumulator::toNative(const ChargePos& pos, const Charge q, t
   if (cn.qTot <= param.rec.tpc.cfQTotCutoff) {
     return false;
   }
-  cn.qMax = q;
-  if (cn.qMax <= param.rec.tpc.cfQMaxCutoff) {
-    return false;
-  }
+  cn.qMax = q; // cfQMaxCutoff check already done at PeakFinder level
   if (mTimeMean < param.rec.tpc.clustersShiftTimebinsClusterizer) {
     return false;
   }
diff --git a/GPU/GPUTracking/TPCClusterFinder/GPUTPCCFPeakFinder.cxx b/GPU/GPUTracking/TPCClusterFinder/GPUTPCCFPeakFinder.cxx
@@ -42,7 +42,7 @@ GPUdii() bool GPUTPCCFPeakFinder::isPeak(
 {
   uint16_t ll = get_local_id(0);
 
-  bool belowThreshold = (q <= calib.tpc.cfQMaxCutoff);
+  bool belowThreshold = (uint32_t)q <= calib.tpc.cfQMaxCutoff;
 
   uint16_t lookForPeaks;
   uint16_t partId = CfUtils::partition<SCRATCH_PAD_WORK_GROUP_SIZE>(

Original file line number	Diff line number	Diff line change
`@@ -98,10 +98,7 @@ GPUd() bool ClusterAccumulator::toNative(const ChargePos& pos, const Charge q, t`
`98`	`98`	`if (cn.qTot <= param.rec.tpc.cfQTotCutoff) {`
`99`	`99`	`return false;`
`100`	`100`	`}`
`101`		`- cn.qMax = q;`
`102`		`- if (cn.qMax <= param.rec.tpc.cfQMaxCutoff) {`
`103`		`- return false;`
`104`		`- }`
	`101`	`+ cn.qMax = q; // cfQMaxCutoff check already done at PeakFinder level`
`105`	`102`	`if (mTimeMean < param.rec.tpc.clustersShiftTimebinsClusterizer) {`
`106`	`103`	`return false;`
`107`	`104`	`}`
Original file line number	Diff line number	Diff line change
`@@ -42,7 +42,7 @@ GPUdii() bool GPUTPCCFPeakFinder::isPeak(`
`42`	`42`	`{`
`43`	`43`	`uint16_t ll = get_local_id(0);`
`44`	`44`
`45`		`- bool belowThreshold = (q <= calib.tpc.cfQMaxCutoff);`
	`45`	`+ bool belowThreshold = (uint32_t)q <= calib.tpc.cfQMaxCutoff;`
`46`	`46`
`47`	`47`	`uint16_t lookForPeaks;`
`48`	`48`	`uint16_t partId = CfUtils::partition<SCRATCH_PAD_WORK_GROUP_SIZE>(`