Skip to content

Commit 9617c62

Browse files
committed
ITS3: fix IB wrapping volume length
Signed-off-by: Felix Schlepper <felix.schlepper@cern.ch>
1 parent fe67204 commit 9617c62

File tree

3 files changed

+6
-3
lines changed

3 files changed

+6
-3
lines changed

Detectors/Upgrades/ITS3/base/include/ITS3Base/SpecsV2.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -221,7 +221,7 @@ namespace services
221221
constexpr double thickness{2.2 * mm}; // thickness of structure
222222
constexpr double radiusInner{radiiOuter[2] + carbonfoam::thicknessOuterFoam}; // inner radius of services
223223
constexpr double radiusOuter{radiusInner + thickness}; // outer radius of services
224-
constexpr double length{20 * cm}; // length
224+
constexpr double length{segment::length + (1 * cm)}; // length
225225
constexpr EColor color{kBlue};
226226
} // namespace services
227227

Detectors/Upgrades/ITS3/simulation/include/ITS3Simulation/DescriptorInnerBarrelITS3.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ class DescriptorInnerBarrelITS3 : public o2::its::DescriptorInnerBarrel
4848
static constexpr double mTolerance{1e-3};
4949
static constexpr double mWrapperMinRadiusITS3{constants::radiiInner[0] - mTolerance};
5050
static constexpr double mWrapperMaxRadiusITS3{constants::services::radiusOuter + mTolerance};
51-
static constexpr double mWrapperZSpanITS3{constants::services::length + mTolerance};
51+
static constexpr double mWrapperZSpanITS3{constants::services::length * 2 + mTolerance}; // z length is divided in half
5252

5353
private:
5454
std::array<std::unique_ptr<ITS3Layer>, constants::nLayers> mIBLayers;

Detectors/Upgrades/ITS3/simulation/src/ITS3Services.cxx

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,13 +30,16 @@ void ITS3Services::createCYSSAssembly(TGeoVolume* motherVolume)
3030
motherVolume->AddNode(cyssVol, 1., nullptr);
3131

3232
// Cylinder
33-
auto cyssInnerCylSh = new TGeoTubeSeg(constants::services::radiusInner, constants::services::radiusOuter, constants::services::length, 180, 360);
33+
auto cyssInnerCylSh = new TGeoTubeSeg(constants::services::radiusInner, constants::services::radiusOuter, constants::services::length / 2, 180, 360);
3434
auto medPrepreg = gGeoManager->GetMedium("IT3_AS4C200$");
3535
auto cyssInnerCylShVol = new TGeoVolume("IBCYSSCylinder", cyssInnerCylSh, medPrepreg);
36+
cyssInnerCylShVol->SetLineColor(constants::services::color);
3637
cyssVol->AddNode(cyssInnerCylShVol, 1, new TGeoTranslation(0, 0, 0));
3738
cyssVol->AddNode(cyssInnerCylShVol, 2, new TGeoCombiTrans(0, 0, 0, new TGeoRotation("", 180, 0, 0)));
3839

3940
// TODO Cone
41+
// For now the wrapping volume just extends beyond the cylinder if something is added beyond that this volume has to
42+
// be exteneded.
4043
}
4144

4245
} // namespace o2::its3

0 commit comments

Comments
 (0)