Skip to content

Commit 8c81c26

Browse files
committed
Fix on the C2F and F2C in SegmentationMosaix class
1 parent b7f0c8c commit 8c81c26

File tree

3 files changed

+7
-7
lines changed

3 files changed

+7
-7
lines changed

Detectors/Upgrades/ITS3/base/include/ITS3Base/SegmentationMosaix.h

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -102,9 +102,9 @@ class SegmentationMosaix
102102
// stack
103103
float dist = std::hypot(xCurved, yCurved);
104104
float phi = std::atan2(yCurved, xCurved);
105-
xFlat = (mRadius * phi) - WidthH;
106105
// the y position is in the silicon volume however we need the chip volume (silicon+metalstack)
107106
// this is accounted by a y shift
107+
xFlat = WidthH - mRadius * phi;
108108
yFlat = dist - mRadius + NominalYShift;
109109
}
110110

@@ -122,11 +122,12 @@ class SegmentationMosaix
122122
{
123123
// MUST align the flat surface with the curved surface with the original pixel array is on and account for metal
124124
// stack
125+
float dist = yFlat - NominalYShift + mRadius;
126+
float phi = (WidthH - xFlat) / mRadius;
125127
// the y position is in the chip volume however we need the silicon volume
126128
// this is accounted by a -y shift
127-
float dist = yFlat - NominalYShift + mRadius;
128-
xCurved = dist * std::cos((xFlat + WidthH) / mRadius);
129-
yCurved = dist * std::sin((xFlat + WidthH) / mRadius);
129+
xCurved = dist * std::cos(phi);
130+
yCurved = dist * std::sin(phi);
130131
}
131132

132133
/// Transformation from Geant detector centered local coordinates (cm) to

Detectors/Upgrades/ITS3/simulation/include/ITS3Simulation/ITS3DPLDigitizerParam.h

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,6 @@
1010

1111
#include "CommonUtils/ConfigurableParam.h"
1212
#include "CommonUtils/ConfigurableParamHelper.h"
13-
#include "ITSMFTSimulation/DPLDigitizerParam.h"
14-
#include <string>
1513

1614
namespace o2
1715
{

Detectors/Upgrades/ITS3/simulation/src/ITS3DPLDigitizerParam.cxx

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,4 +17,5 @@ namespace its3
1717
{
1818
static auto& sDigitizerParamITS3 = o2::its3::ITS3DPLDigitizerParam::Instance();
1919
} // namespace its3
20-
} // namespace o2
20+
} // namespace o2
21+
O2ParamImpl(o2::its3::ITS3DPLDigitizerParam)

0 commit comments

Comments
 (0)