Skip to content

Commit 8c7bad7

Browse files
committed
GPU TPC: Add some TODO comments
1 parent e5bcc6b commit 8c7bad7

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

GPU/GPUTracking/Merger/GPUTPCGMTrackParam.cxx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -370,7 +370,7 @@ GPUd() bool GPUTPCGMTrackParam::Fit(GPUTPCGMMerger* GPUrestrict() merger, int32_
370370
CADEBUG(printf("Reinit linearization\n"));
371371
prop.SetTrack(this, prop.GetAlpha());
372372
}
373-
if (param.par.dodEdx && param.dodEdxDownscaled && iWay == nWays - 1 && cluster.leg == clusters[maxN - 1].leg && !(clusterState & GPUTPCGMMergedTrackHit::flagEdge)) {
373+
if (param.par.dodEdx && param.dodEdxDownscaled && iWay == nWays - 1 && cluster.leg == clusters[maxN - 1].leg && !(clusterState & GPUTPCGMMergedTrackHit::flagEdge)) { // TODO: Costimize flag to remove, and option to remove double-clusters
374374
float qtot = 0, qmax = 0, pad = 0, relTime = 0;
375375
const int32_t clusterCount = (ihit - ihitMergeFirst) * wayDirection + 1;
376376
for (int32_t iTmp = ihitMergeFirst; iTmp != ihit + wayDirection; iTmp += wayDirection) {
@@ -384,7 +384,7 @@ GPUd() bool GPUTPCGMTrackParam::Fit(GPUTPCGMMerger* GPUrestrict() merger, int32_
384384
relTime += cl.getTime();
385385
}
386386
}
387-
qtot /= clusterCount;
387+
qtot /= clusterCount; // TODO: Weighted Average
388388
pad /= clusterCount;
389389
relTime /= clusterCount;
390390
relTime = relTime - CAMath::Round(relTime);
@@ -528,7 +528,7 @@ GPUd() int32_t GPUTPCGMTrackParam::MergeDoubleRowClusters(int32_t& ihit, int32_t
528528
}
529529
} else {
530530
CADEBUG(printf("\t\tMerging hit row %d X %f Y %f Z %f (dy %f, dz %f, chiY %f, chiZ %f)\n", clusters[ihit].row, clx, cly, clz, dy, dz, sqrtf(maxDistY), sqrtf(maxDistZ)));
531-
xx += clx * clamp;
531+
xx += clx * clamp; // TODO: Weight in pad/time instead of XYZ
532532
yy += cly * clamp;
533533
zz += clz * clamp;
534534
clusterState |= clusters[ihit].state;

0 commit comments

Comments
 (0)