Skip to content

Commit 81dede4

Browse files
committed
ONNX: Use CMake defines not env variables
1 parent fad8881 commit 81dede4

File tree

2 files changed

+8
-14
lines changed

2 files changed

+8
-14
lines changed

Common/ML/CMakeLists.txt

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -10,17 +10,17 @@
1010
# or submit itself to any jurisdiction.
1111

1212
# Pass ORT variables as a preprocessor definition
13-
if(DEFINED ENV{ORT_ROCM_BUILD})
14-
add_compile_definitions(ORT_ROCM_BUILD=$ENV{ORT_ROCM_BUILD})
13+
if(ORT_ROCM_BUILD)
14+
add_compile_definitions(ORT_ROCM_BUILD=1)
1515
endif()
16-
if(DEFINED ENV{ORT_CUDA_BUILD})
17-
add_compile_definitions(ORT_CUDA_BUILD=$ENV{ORT_CUDA_BUILD})
16+
if(ORT_CUDA_BUILD)
17+
add_compile_definitions(ORT_CUDA_BUILD=1)
1818
endif()
19-
if(DEFINED ENV{ORT_MIGRAPHX_BUILD})
20-
add_compile_definitions(ORT_MIGRAPHX_BUILD=$ENV{ORT_MIGRAPHX_BUILD})
19+
if(ORT_MIGRAPHX_BUILD)
20+
add_compile_definitions(ORT_MIGRAPHX_BUILD=1)
2121
endif()
22-
if(DEFINED ENV{ORT_TENSORRT_BUILD})
23-
add_compile_definitions(ORT_TENSORRT_BUILD=$ENV{ORT_TENSORRT_BUILD})
22+
if(ORT_TENSORRT_BUILD)
23+
add_compile_definitions(ORT_TENSORRT_BUILD=1)
2424
endif()
2525

2626
o2_add_library(ML

Common/ML/src/OrtInterface.cxx

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -59,29 +59,23 @@ void OrtModel::reset(std::unordered_map<std::string, std::string> optionsMap)
5959

6060
std::string dev_mem_str = "Hip";
6161
#if defined(ORT_ROCM_BUILD)
62-
#if ORT_ROCM_BUILD == 1
6362
if (device == "ROCM") {
6463
Ort::ThrowOnError(OrtSessionOptionsAppendExecutionProvider_ROCM(pImplOrt->sessionOptions, deviceId));
6564
LOG(info) << "(ORT) ROCM execution provider set";
6665
}
6766
#endif
68-
#endif
6967
#if defined(ORT_MIGRAPHX_BUILD)
70-
#if ORT_MIGRAPHX_BUILD == 1
7168
if (device == "MIGRAPHX") {
7269
Ort::ThrowOnError(OrtSessionOptionsAppendExecutionProvider_MIGraphX(pImplOrt->sessionOptions, deviceId));
7370
LOG(info) << "(ORT) MIGraphX execution provider set";
7471
}
7572
#endif
76-
#endif
7773
#if defined(ORT_CUDA_BUILD)
78-
#if ORT_CUDA_BUILD == 1
7974
if (device == "CUDA") {
8075
Ort::ThrowOnError(OrtSessionOptionsAppendExecutionProvider_CUDA(pImplOrt->sessionOptions, deviceId));
8176
LOG(info) << "(ORT) CUDA execution provider set";
8277
dev_mem_str = "Cuda";
8378
}
84-
#endif
8579
#endif
8680

8781
if (allocateDeviceMemory) {

0 commit comments

Comments
 (0)