Skip to content

Commit 7b38fb1

Browse files
authored
Fix CHANGELOG generation (#5109)
1 parent 47d1a6a commit 7b38fb1

File tree

1 file changed

+7
-12
lines changed

1 file changed

+7
-12
lines changed

.github/workflows/reports.yml

Lines changed: 7 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -86,12 +86,12 @@ jobs:
8686
cat <<\EOF > doc/data/${CURRENT_MONTH}-o2_prs.json
8787
${{ steps.get_latest_o2_prs.outputs.data }}
8888
EOF
89-
# FIXME: this should really be one second after the last release
89+
# FIXME: this should really be one second after the last release
9090
# being published
9191
MERGED_AFTER=`date -v -14d +%Y-%m-%d`
9292
93-
# Here we convert all the json files to per subsystem
94-
# logs, using the MERGED_AFTER date to further filter them.
93+
# Here we convert all the json files to per subsystem
94+
# logs, using the MERGED_AFTER date to further filter them.
9595
# Notice we can have duplicates in each file,
9696
# as they will be removed in the next iteration.
9797
# FIXME: it's probably enough to iterate on the last two
@@ -104,17 +104,12 @@ jobs:
104104
fi
105105
done
106106
done
107-
# Here we do the merging by iterating on the subsystems adding
107+
# Here we do the merging by iterating on the subsystems adding
108108
# an header for each and removing the duplicates.
109-
cat << EOF > CHANGELOG.md
110-
# Changes since ${MERGED_AFTER}
111-
112-
EOF
113-
109+
printf "# Changes since ${MERGED_AFTER}\n\n" > CHANGELOG.md
114110
for x in Algorithm Analysis Common DataFormats Detectors EventVisualisation Examples Framework Generators Steer Testing Utilities; do
115-
cat << EOF >> CHANGELOG.md
116-
## Changes in $x
117-
EOF
111+
[ ! -f /tmp/${x}_prs.md ] && continue
112+
printf "## Changes in $x\n\n" >> CHANGELOG.md
118113
cat /tmp/${x}_prs.md | sort -k3 | uniq >> CHANGELOG.md
119114
done
120115
- name: Commit and push if changed

0 commit comments

Comments
 (0)