FIT: changed return type to float in fv0::ChannelDataFloat::getTime and fv0::ChannelDataFloat::getAmp; added no discard to getters in fv0::ChannelDataFloat, fdd::ChannelDataFloat, ft0::ChannelDataFloat

Author: wpierozak

DataFormats/Detectors/FIT/FDD/include/DataFormatsFDD/RecPoint.h

@@ -63,11 +63,11 @@ struct ChannelDataFloat {
   {
     adcId = uint8_t(adcId) | uint8_t(value) << uint8_t(bitFlag);
   }
-  bool getFlag(fit::EEventDataBit bitFlag) const
+  [[nodiscard]] bool getFlag(fit::EEventDataBit bitFlag) const
   {
     return bool(uint8_t(adcId) & (1u << uint8_t(bitFlag)));
   }
-  bool areAllFlagsGood() const
+  [[nodiscard]] bool areAllFlagsGood() const
   {
     return (!getFlag(fit::EEventDataBit::kIsDoubleEvent) &&
             !getFlag(fit::EEventDataBit::kIsTimeInfoNOTvalid) &&

DataFormats/Detectors/FIT/FT0/include/DataFormatsFT0/RecPoints.h

@@ -69,11 +69,11 @@ struct ChannelDataFloat {
   {
     ChainQTC = uint8_t(ChainQTC) | uint8_t(value) << uint8_t(bitFlag);
   }
-  bool getFlag(fit::EEventDataBit bitFlag) const
+  [[nodiscard]] bool getFlag(fit::EEventDataBit bitFlag) const
   {
     return bool(uint8_t(ChainQTC) & (1u << uint8_t(bitFlag)));
   }
-  bool areAllFlagsGood() const
+  [[nodiscard]] bool areAllFlagsGood() const
   {
     return (!getFlag(fit::EEventDataBit::kIsDoubleEvent) &&
             !getFlag(fit::EEventDataBit::kIsTimeInfoNOTvalid) &&

DataFormats/Detectors/FIT/FV0/include/DataFormatsFV0/RecPoints.h

@@ -58,11 +58,11 @@ struct ChannelDataFloat {
   {
     adcId = flag;
   }
-  bool getFlag(fit::EEventDataBit bitFlag) const
+  [[nodiscard]] bool getFlag(fit::EEventDataBit bitFlag) const
   {
     return bool(uint8_t(adcId) & (1u << uint8_t(bitFlag)));
   }
-  bool areAllFlagsGood() const
+  [[nodiscard]] bool areAllFlagsGood() const
   {
     return (!getFlag(fit::EEventDataBit::kIsDoubleEvent) &&
             !getFlag(fit::EEventDataBit::kIsTimeInfoNOTvalid) &&
@@ -75,8 +75,8 @@ struct ChannelDataFloat {
 
   void print() const;
   [[nodiscard]] int getChannelId() const { return channel; }
-  [[nodiscard]] int getTime() const { return time; }
-  [[nodiscard]] int getAmp() const { return charge; }
+  [[nodiscard]] double getTime() const { return time; }
+  [[nodiscard]] double getAmp() const { return charge; }
   bool operator==(const ChannelDataFloat&) const = default;
 
   ClassDefNV(ChannelDataFloat, 1);