Skip to content

Commit 769e674

Browse files
authored
DPL Analysis: fix is_preslice concept (#13990)
1 parent a88d10c commit 769e674

File tree

2 files changed

+3
-7
lines changed

2 files changed

+3
-7
lines changed

Framework/Core/include/Framework/ASoA.h

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1455,13 +1455,7 @@ template <typename T>
14551455
using PresliceOptional = PresliceBase<T, PreslicePolicySorted, true>;
14561456

14571457
template <typename T>
1458-
concept is_preslice = requires(T t) {
1459-
requires std::same_as<decltype(t.binding), std::string>;
1460-
requires std::same_as<decltype(t.bindingKey), StringPair>;
1461-
&T::isMising;
1462-
&T::updateSliceInfo;
1463-
&T::getSliceFor;
1464-
};
1458+
concept is_preslice = std::derived_from<T, PreslicePolicyBase>;
14651459

14661460
} // namespace o2::framework
14671461

Framework/Core/include/Framework/AnalysisManagers.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -511,6 +511,7 @@ static void setGroupedCombination(C& comb, TG& grouping, std::tuple<Ts...>& asso
511511

512512
/// Preslice handling
513513
template <typename T>
514+
requires(!is_preslice<T>)
514515
bool registerCache(T&, std::vector<StringPair>&, std::vector<StringPair>&)
515516
{
516517
return false;
@@ -549,6 +550,7 @@ bool registerCache(T& preslice, std::vector<StringPair>&, std::vector<StringPair
549550
}
550551

551552
template <typename T>
553+
requires(!is_preslice<T>)
552554
bool updateSliceInfo(T&, ArrowTableSlicingCache&)
553555
{
554556
return false;

0 commit comments

Comments
 (0)