Skip to content

Commit 56d4e95

Browse files
martenoledavidrohr
authored andcommitted
Remove Tracklet64 inheritance from CalibratedTracklet
1 parent 0176bab commit 56d4e95

File tree

3 files changed

+5
-11
lines changed

3 files changed

+5
-11
lines changed

DataFormats/Detectors/TRD/include/DataFormatsTRD/CalibratedTracklet.h

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,6 @@
1111
#ifndef O2_TRD_CALIBRATEDTRACKLET_H
1212
#define O2_TRD_CALIBRATEDTRACKLET_H
1313

14-
#include "DataFormatsTRD/Tracklet64.h"
15-
1614
namespace o2
1715
{
1816
namespace trd
@@ -21,12 +19,12 @@ namespace trd
2119
// The CalibratedTracklet has been calibrated in x and dy according to a calculated Lorentz Angle and Drift Velocity.
2220
// Tracklet positions in local z direction are reported at the center of the pad-row.
2321
// Pad-tilting correction is performed after tracking.
24-
class CalibratedTracklet : public Tracklet64 // OS: why do we inherit from Tracklet64? Should this not be an independent, transient data type?
22+
class CalibratedTracklet
2523
{
2624
public:
2725
CalibratedTracklet() = default;
28-
CalibratedTracklet(uint64_t trackletWord, float x, float y, float z, float dy)
29-
: Tracklet64(trackletWord), mx(x), my(y), mz(z), mdy(dy){};
26+
CalibratedTracklet(float x, float y, float z, float dy)
27+
: mx(x), my(y), mz(z), mdy(dy){};
3028
~CalibratedTracklet() = default;
3129

3230
float getX() const { return mx; }

Detectors/TRD/base/src/TrackletTransformer.cxx

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -141,7 +141,6 @@ std::array<float, 3> TrackletTransformer::transformL2T(int hcid, std::array<doub
141141

142142
CalibratedTracklet TrackletTransformer::transformTracklet(Tracklet64 tracklet)
143143
{
144-
uint64_t trackletWord = tracklet.getTrackletWord();
145144
uint64_t hcid = tracklet.getHCID();
146145
uint64_t padrow = tracklet.getPadRow();
147146
uint64_t column = tracklet.getColumn();
@@ -164,7 +163,5 @@ CalibratedTracklet TrackletTransformer::transformTracklet(Tracklet64 tracklet)
164163
<< "y: " << sectorSpacePoint[1] << " | "
165164
<< "z: " << sectorSpacePoint[2];
166165

167-
CalibratedTracklet calibratedTracklet = CalibratedTracklet(trackletWord, sectorSpacePoint[0], sectorSpacePoint[1], sectorSpacePoint[2], dy);
168-
169-
return calibratedTracklet;
166+
return CalibratedTracklet(sectorSpacePoint[0], sectorSpacePoint[1], sectorSpacePoint[2], dy);
170167
}

Detectors/TRD/workflow/src/TRDTrackletTransformerSpec.cxx

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -48,8 +48,7 @@ void TRDTrackletTransformerSpec::run(o2::framework::ProcessingContext& pc)
4848
LOG(info) << tracklets.size() << " tracklets found!";
4949

5050
for (const auto& tracklet : tracklets) {
51-
CalibratedTracklet calibratedTracklet = mTransformer.transformTracklet(tracklet);
52-
calibratedTracklets.push_back(calibratedTracklet);
51+
calibratedTracklets.push_back(mTransformer.transformTracklet(tracklet));
5352
}
5453

5554
pc.outputs().snapshot(Output{"TRD", "CTRACKLETS", 0, Lifetime::Timeframe}, calibratedTracklets);

0 commit comments

Comments
 (0)