DPL Analysis: signed comparison fix (#13316)

aalkin · web-flow · commit 53d086a65176 · 2024-07-23T12:50:29.000+02:00
diff --git a/Framework/Core/include/Framework/ASoA.h b/Framework/Core/include/Framework/ASoA.h
@@ -1291,7 +1291,7 @@ auto doSliceBy(T const* table, o2::framework::PresliceBase<C, OPT, SORTED> const
 template <typename T>
 auto prepareFilteredSlice(T const* table, std::shared_ptr<arrow::Table> slice, uint64_t offset)
 {
-  if (offset >= table->tableSize()) {
+  if (offset >= static_cast<uint64_t>(table->tableSize())) {
     if constexpr (soa::is_soa_filtered_v<T>) {
       Filtered<typename T::base_t> fresult{{{slice}}, SelectionVector{}, 0};
       table->copyIndexBindings(fresult);

Original file line number	Diff line number	Diff line change
`@@ -1291,7 +1291,7 @@ auto doSliceBy(T const* table, o2::framework::PresliceBase<C, OPT, SORTED> const`
`1291`	`1291`	`template <typename T>`
`1292`	`1292`	`auto prepareFilteredSlice(T const* table, std::shared_ptr<arrow::Table> slice, uint64_t offset)`
`1293`	`1293`	`{`
`1294`		`- if (offset >= table->tableSize()) {`
	`1294`	`+ if (offset >= static_cast<uint64_t>(table->tableSize())) {`
`1295`	`1295`	`if constexpr (soa::is_soa_filtered_v<T>) {`
`1296`	`1296`	`Filtered<typename T::base_t> fresult{{{slice}}, SelectionVector{}, 0};`
`1297`	`1297`	`table->copyIndexBindings(fresult);`