Skip to content

Commit 4e90ae6

Browse files
committed
Ignore signals for now
1 parent cc41c89 commit 4e90ae6

File tree

2 files changed

+8
-4
lines changed

2 files changed

+8
-4
lines changed

Framework/Core/src/DataProcessingDevice.cxx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1085,8 +1085,8 @@ void DataProcessingDevice::InitTask()
10851085
if (deviceContext.sigusr1Handle == nullptr) {
10861086
deviceContext.sigusr1Handle = (uv_signal_t*)malloc(sizeof(uv_signal_t));
10871087
deviceContext.sigusr1Handle->data = &mServiceRegistry;
1088-
uv_signal_init(state.loop, deviceContext.sigusr1Handle);
1089-
uv_signal_start(deviceContext.sigusr1Handle, on_signal_callback, SIGUSR1);
1088+
// uv_signal_init(state.loop, deviceContext.sigusr1Handle);
1089+
// uv_signal_start(deviceContext.sigusr1Handle, on_signal_callback, SIGUSR1);
10901090
}
10911091
// If there is any signal, we want to make sure they are active
10921092
for (auto& handle : state.activeSignals) {

Framework/Core/src/runDataProcessing.cxx

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -729,8 +729,12 @@ std::string spawnDevice(uv_loop_t* loop,
729729
// get killed by the parent trying to force stepping children.
730730
// We will re-enable them later on, when it is actually safe to
731731
// do so.
732-
signal(SIGUSR1, SIG_IGN);
733-
signal(SIGUSR2, SIG_IGN);
732+
// We do not do so if the plugin is there, because that confuses libuv
733+
// FIXME: maybe use libuv to ignore?
734+
if (execution.plugin.empty()) {
735+
signal(SIGUSR1, SIG_IGN);
736+
signal(SIGUSR2, SIG_IGN);
737+
}
734738

735739
// This is the child.
736740
// For stdout / stderr, we close the read part of the pipe, the

0 commit comments

Comments
 (0)