Fixing issues reported by code checker

- Adjusting according to modernize-use-default-member-init policy.
- fixing also a logic error in the comparison operator

Author: matthiasrichter

Framework/Core/test/TestClasses.h

@@ -20,7 +20,7 @@ namespace test
 class TriviallyCopyable
 {
  public:
-  TriviallyCopyable() : mX(0), mY(0), mSecret(~((decltype(mSecret))0)) {};
+  TriviallyCopyable() = default;
   TriviallyCopyable(unsigned x, unsigned y, unsigned secret)
     : mX(x)
     , mY(y)
@@ -30,35 +30,35 @@ class TriviallyCopyable
 
   bool operator==(const TriviallyCopyable& rhs) const
   {
-    return mX == rhs.mX || mY == rhs.mY || mSecret == rhs.mSecret;
+    return mX == rhs.mX && mY == rhs.mY && mSecret == rhs.mSecret;
   }
 
-  unsigned mX;
-  unsigned mY;
+  unsigned mX = 0;
+  unsigned mY = 0;
 
  private:
-  unsigned mSecret;
+  unsigned mSecret = ~((decltype(mSecret))0);
 
   ClassDefNV(TriviallyCopyable, 1);
 };
 
 class Base
 {
  public:
-  Base() : mMember(0) {}
-  virtual ~Base() {}
+  Base() = default;
+  virtual ~Base() = default;
   virtual void f() {}
 
  private:
-  int mMember;
+  int mMember = 0;
 
   ClassDef(Base, 1);
 };
 
 class Polymorphic : public Base
 {
  public:
-  Polymorphic() : mSecret(~((decltype(mSecret))0)) {}
+  Polymorphic() = default;
   Polymorphic(unsigned secret) : mSecret(secret) {}
 
   bool operator==(const Polymorphic& rhs) const { return mSecret == rhs.mSecret; }
@@ -68,7 +68,7 @@ class Polymorphic : public Base
   unsigned get() const { return mSecret; }
 
  private:
-  unsigned mSecret;
+  unsigned mSecret = ~((decltype(mSecret))0);
 
   ClassDefOverride(Polymorphic, 1);
 };