Feat: update gpu error task

Author: ariedel-cern

Detectors/TPC/qc/include/TPCQC/GPUErrorQA.h

@@ -18,23 +18,20 @@
 #define AliceO2_TPC_QC_GPUERRORQA_H
 
 #include <memory>
+#include <string>
+#include <vector>
 #include <unordered_map>
-#include <gsl/span>
 
 // root includes
-#include "TH1.h"
 
 // o2 includes
 // #include "DataFormatsTPC/Defs.h"
 
-namespace o2
-{
-namespace tpc
-{
-namespace qc
+class TH1;
+namespace o2::tpc::qc
 {
 
-/// @brief  TPC QC task for errors from GPU reconstruction
+/// @brief TPC QC task for errors from GPU reconstruction
 ///
 /// This class is used to retrieve and visualize GPU errors
 /// according to corresponding error code and location.
@@ -48,7 +45,7 @@ class GPUErrorQA
   GPUErrorQA() = default;
 
   /// process gpu error reported by the reconstruction workflow
-  void processErrors(gsl::span<const std::array<uint32_t, 4>> errors);
+  void processErrors(std::vector<std::array<uint32_t, 4>> errors);
 
   /// Initialize all histograms
   void initializeHistograms();
@@ -57,17 +54,16 @@ class GPUErrorQA
   void resetHistograms();
 
   /// return histograms
-  std::unordered_map<std::string, std::unique_ptr<TH1>>& getMapHist() { return mMapHist; };
+  const std::unordered_map<std::string, std::unique_ptr<TH1>>& getMapHist() const { return mMapHist; };
 
   /// Dump results to a file
   void dumpToFile(std::string filename);
 
  private:
   std::unordered_map<std::string, std::unique_ptr<TH1>> mMapHist;
-  ClassDefNV(GPUErrorQA, 1)
+
+  ClassDefNV(GPUErrorQA, 1);
 };
-} // namespace qc
-} // namespace tpc
-} // namespace o2
+} // namespace o2::tpc::qc
 
 #endif // AliceO2_TPC_QC_GPUERRORQA_H

Detectors/TPC/qc/src/GPUErrorQA.cxx

@@ -11,13 +11,9 @@
 
 #define _USE_MATH_DEFINES
 
-#include <cmath>
-#include <memory>
-#include <unordered_map>
-
 // root includes
 #include "TFile.h"
-#include <TH1.h>
+#include "TH1I.h"
 
 // o2 includes
 #include "TPCQC/GPUErrorQA.h"
@@ -41,7 +37,7 @@ void GPUErrorQA::initializeHistograms()
   };
 
   // 1D histogram counting all reported errors
-  mMapHist["ErrorCounter"] = std::make_unique<TH1F>("ErrorCounter", "ErrorCounter", errorNames.size(), 0, errorNames.size());
+  mMapHist["ErrorCounter"] = std::make_unique<TH1I>("ErrorCounter", "ErrorCounter", errorNames.size(), -0.5, errorNames.size() - 0.5);
   mMapHist["ErrorCounter"]->GetXaxis()->SetTitle("Error Codes");
   mMapHist["ErrorCounter"]->GetYaxis()->SetTitle("Entries");
   // for convienence, label each bin with the error name
@@ -58,22 +54,22 @@ void GPUErrorQA::resetHistograms()
   }
 }
 //______________________________________________________________________________
-void GPUErrorQA::processErrors(gsl::span<const std::array<uint32_t, 4>> errors)
+void GPUErrorQA::processErrors(std::vector<std::array<uint32_t, 4>> errors)
 {
   for (const auto& error : errors) {
     uint32_t errorCode = error[0];
-    mMapHist["ErrorCounter"]->Fill(static_cast<float>(errorCode));
+    mMapHist["ErrorCounter"]->AddBinContent(errorCode);
   }
 }
 
 //______________________________________________________________________________
 void GPUErrorQA::dumpToFile(const std::string filename)
 {
   auto f = std::unique_ptr<TFile>(TFile::Open(filename.data(), "recreate"));
+  TObjArray arr;
+  arr.SetName("GPUErrorQA_Hists");
   for (const auto& [name, hist] : mMapHist) {
-    TObjArray arr;
-    arr.SetName(name.data());
     arr.Add(hist.get());
-    arr.Write(arr.GetName(), TObject::kSingleKey);
   }
+  arr.Write(arr.GetName(), TObject::kSingleKey);
 }