Skip to content

Commit 402c018

Browse files
committed
Restrict random col index. The problem is in cache lines
1 parent cc50851 commit 402c018

File tree

1 file changed

+7
-6
lines changed

1 file changed

+7
-6
lines changed

Framework/Core/test/benchmark_EventMixing.cxx

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ static void BM_EventMixingTraditional(benchmark::State& state)
6464
}
6565
auto tableCol = colBuilder.finalize();
6666
o2::aod::Collisions collisions{tableCol};
67-
std::uniform_int_distribution<int> uniform_dist_col_ind(0, collisions.size());
67+
std::uniform_int_distribution<int> uniform_dist_col_ind(0, collisions.size() - 1);
6868

6969
auto rowWriterTrack = trackBuilder.cursor<o2::aod::StoredTracks>();
7070
for (auto i = 0; i < numTracksPerEvent * state.range(0); ++i) {
@@ -76,14 +76,14 @@ static void BM_EventMixingTraditional(benchmark::State& state)
7676
auto tableTrack = trackBuilder.finalize();
7777
o2::aod::StoredTracks tracks{tableTrack};
7878

79-
ArrowTableSlicingCache atscache({{getLabelFromType<o2::aod::StoredTracks>(), "fIndex" + cutString(getLabelFromType<o2::aod::Collisions>())}});
80-
auto s = atscache.updateCacheEntry(0, tableTrack);
81-
SliceCache cache{&atscache};
82-
8379
int64_t count = 0;
8480
int64_t colCount = 0;
8581
int nBinsTot = (xBins.size() - 2) * (yBins.size() - 2);
8682

83+
ArrowTableSlicingCache atscache({{getLabelFromType<o2::aod::StoredTracks>(), "fIndex" + cutString(getLabelFromType<o2::aod::Collisions>())}});
84+
auto s = atscache.updateCacheEntry(0, tableTrack);
85+
SliceCache cache{&atscache};
86+
8787
for (auto _ : state) {
8888
count = 0;
8989
colCount = 0;
@@ -155,7 +155,7 @@ static void BM_EventMixingCombinations(benchmark::State& state)
155155
}
156156
auto tableCol = colBuilder.finalize();
157157
o2::aod::Collisions collisions{tableCol};
158-
std::uniform_int_distribution<int> uniform_dist_col_ind(0, collisions.size());
158+
std::uniform_int_distribution<int> uniform_dist_col_ind(0, collisions.size() - 1);
159159

160160
auto rowWriterTrack = trackBuilder.cursor<o2::aod::StoredTracks>();
161161
for (auto i = 0; i < numTracksPerEvent * state.range(0); ++i) {
@@ -169,6 +169,7 @@ static void BM_EventMixingCombinations(benchmark::State& state)
169169

170170
int64_t count = 0;
171171
int64_t colCount = 0;
172+
172173
ArrowTableSlicingCache atscache{{{getLabelFromType<o2::aod::StoredTracks>(), "fIndex" + getLabelFromType<o2::aod::Collisions>()}}};
173174
auto s = atscache.updateCacheEntry(0, tableTrack);
174175
SliceCache cache{&atscache};

0 commit comments

Comments
 (0)