Use ternary expression to avoid repetition

Co-authored-by: Giulio Eulisse <10544+ktf@users.noreply.github.com>

Author: nicolaspoffley

Framework/Core/src/HTTPParser.cxx

@@ -216,24 +216,14 @@ std::string HTTPParserHelpers::calculateAccept(const char* nonce)
 
 std::string encode_websocket_handshake_reply(char const* nonce, char const* protocol = "")
 {
-  if (strlen(protocol) == 0) {
-    constexpr auto res =
-      "HTTP/1.1 101 Switching Protocols\r\n"
-      "Upgrade: websocket\r\n"
-      "Connection: Upgrade\r\n"
-      "Access-Control-Allow-Origin: \"*\"\r\n"
-      "Sec-WebSocket-Accept: {}\r\n\r\n";
-    return fmt::format(res, HTTPParserHelpers::calculateAccept(nonce));
-  } else {
-    constexpr auto res =
-      "HTTP/1.1 101 Switching Protocols\r\n"
-      "Upgrade: websocket\r\n"
-      "Connection: Upgrade\r\n"
-      "Access-Control-Allow-Origin: \"*\"\r\n"
-      "Sec-WebSocket-Protocol: {}\r\n"
-      "Sec-WebSocket-Accept: {}\r\n\r\n";
-    return fmt::format(res, protocol, HTTPParserHelpers::calculateAccept(nonce));
-  }
+  constexpr auto res =
+    "HTTP/1.1 101 Switching Protocols\r\n"
+    "Upgrade: websocket\r\n"
+    "Connection: Upgrade\r\n"
+    "Access-Control-Allow-Origin: \"*\"\r\n"
+    "{}"   
+    "Sec-WebSocket-Accept: {}\r\n\r\n";
+  return fmt::format(res, protocol && protocol[0] ? fmt::format("Sec-WebSocket-Protocol: {}\r\n", protocol) : "", HTTPParserHelpers::calculateAccept(nonce));
 }
 
 void parse_http_request(char* start, size_t size, HTTPParser* parser)