DPL: correct oldest possible timeframe for readout-proxy

ktf · ktf · commit 2b3269a81a6b · 2022-05-03T23:25:40.000+02:00
The oldest possible timeframe is not the one we just sent, but
the one after.
diff --git a/Framework/Core/src/ExternalFairMQDeviceProxy.cxx b/Framework/Core/src/ExternalFairMQDeviceProxy.cxx
@@ -100,7 +100,10 @@ void sendOnChannel(FairMQDevice& device, FairMQParts& messages, std::string cons
     }
   }
   if (timeSlice != (size_t)-1) {
-    o2::framework::DataProcessingHelpers::sendOldestPossibleTimeframe(device.GetChannel(channel, 0), timeSlice);
+    // We propagate the information about the oldest possible timeframe downstream.
+    // Notice that the oldest possible timeframe is not the one we just sent, but the one
+    // after because we know we will not send twice the same timeframe.
+    o2::framework::DataProcessingHelpers::sendOldestPossibleTimeframe(device.GetChannel(channel, 0), timeSlice + 1);
   }
   // FIXME: we need a better logic for avoiding message spam
   if (timeout > 1 && timeout <= maxTimeout) {

Original file line number	Diff line number	Diff line change
`@@ -100,7 +100,10 @@ void sendOnChannel(FairMQDevice& device, FairMQParts& messages, std::string cons`
`100`	`100`	`}`
`101`	`101`	`}`
`102`	`102`	`if (timeSlice != (size_t)-1) {`
`103`		`- o2::framework::DataProcessingHelpers::sendOldestPossibleTimeframe(device.GetChannel(channel, 0), timeSlice);`
	`103`	`+ // We propagate the information about the oldest possible timeframe downstream.`
	`104`	`+ // Notice that the oldest possible timeframe is not the one we just sent, but the one`
	`105`	`+ // after because we know we will not send twice the same timeframe.`
	`106`	`+ o2::framework::DataProcessingHelpers::sendOldestPossibleTimeframe(device.GetChannel(channel, 0), timeSlice + 1);`
`104`	`107`	`}`
`105`	`108`	`// FIXME: we need a better logic for avoiding message spam`
`106`	`109`	`if (timeout > 1 && timeout <= maxTimeout) {`