Remove Lifetime specification from Output

The .lifetime field in Output is to be removed. This includes
cases in which the value is not the default.

Author: ktf

Detectors/GlobalTrackingWorkflow/src/GlobalFwdMatchingAssessmentSpec.cxx

@@ -109,7 +109,7 @@ void GlobalFwdAssessmentSpec::sendOutput(DataAllocator& output)
   TObjArray objar;
   mGloFwdAssessment->getHistos(objar);
 
-  output.snapshot(Output{"GLO", "FWDASSESSMENT", 0, Lifetime::Sporadic}, objar);
+  output.snapshot(Output{"GLO", "FWDASSESSMENT", 0}, objar);
 
   TFile* f = new TFile(Form("GlobalForwardAssessment.root"), "RECREATE");
   objar.Write();

Detectors/ITSMFT/MFT/workflow/src/MFTAssessmentSpec.cxx

@@ -90,7 +90,7 @@ void MFTAssessmentSpec::sendOutput(DataAllocator& output)
   TObjArray objar;
   mMFTAssessment->getHistos(objar);
 
-  output.snapshot(Output{"MFT", "MFTASSESSMENT", 0, Lifetime::Sporadic}, objar);
+  output.snapshot(Output{"MFT", "MFTASSESSMENT", 0}, objar);
 
   TFile* f = new TFile(Form("MFTAssessment.root"), "RECREATE");
   objar.Write();

Detectors/PHOS/calib/src/PHOSL1phaseCalibDevice.cxx

@@ -71,7 +71,7 @@ void PHOSL1phaseCalibDevice::endOfStream(o2::framework::EndOfStreamContext& ec)
   ec.outputs().snapshot(Output{o2::calibration::Utils::gDataOriginCDBWrapper, "PHOS_L1phase", 0}, info);
   // Send summary to QC
   LOG(info) << "Sending histos to QC ";
-  ec.outputs().snapshot(o2::framework::Output{"PHS", "L1PHASEHISTO", 0, o2::framework::Lifetime::Sporadic}, mCalibrator->getQcHistos());
+  ec.outputs().snapshot(o2::framework::Output{"PHS", "L1PHASEHISTO", 0}, mCalibrator->getQcHistos());
 }
 
 o2::framework::DataProcessorSpec o2::phos::getPHOSL1phaseCalibDeviceSpec()

Detectors/PHOS/workflow/src/RawToCellConverterSpec.cxx

@@ -115,7 +115,7 @@ void RawToCellConverterSpec::run(framework::ProcessingContext& ctx)
       ctx.outputs().snapshot(o2::framework::Output{"PHS", "RAWHWERRORS", 0, o2::framework::Lifetime::Timeframe}, mOutputHWErrors);
       if (mFillChi2) {
         mOutputFitChi.clear();
-        ctx.outputs().snapshot(o2::framework::Output{"PHS", "CELLFITQA", 0, o2::framework::Lifetime::QA}, mOutputFitChi);
+        ctx.outputs().snapshot(o2::framework::Output{"PHS", "CELLFITQA", 0}, mOutputFitChi);
       }
       return; // empty TF, nothing to process
     }
@@ -294,7 +294,7 @@ void RawToCellConverterSpec::run(framework::ProcessingContext& ctx)
   ctx.outputs().snapshot(o2::framework::Output{"PHS", "CELLTRIGREC", mflpId, o2::framework::Lifetime::Timeframe}, mOutputTriggerRecords);
   ctx.outputs().snapshot(o2::framework::Output{"PHS", "RAWHWERRORS", 0, o2::framework::Lifetime::Timeframe}, mOutputHWErrors);
   if (mFillChi2) {
-    ctx.outputs().snapshot(o2::framework::Output{"PHS", "CELLFITQA", 0, o2::framework::Lifetime::QA}, mOutputFitChi);
+    ctx.outputs().snapshot(o2::framework::Output{"PHS", "CELLFITQA", 0}, mOutputFitChi);
   }
 }
 

Detectors/TPC/workflow/include/TPCWorkflow/TPCDistributeSACSpec.h

@@ -102,7 +102,7 @@ class TPCDistributeSACSpec : public o2::framework::Task
   void sendOutput(o2::framework::ProcessingContext& pc)
   {
     LOGP(info, "Sending SACs on lane: {} for {} TFs", mCurrentOutLane, mProcessedTFs);
-    pc.outputs().snapshot(Output{gDataOriginTPC, getDataDescriptionSACCCDB(), 0, Lifetime::Sporadic}, mCCDBTimeStamp);
+    pc.outputs().snapshot(Output{gDataOriginTPC, getDataDescriptionSACCCDB(), 0}, mCCDBTimeStamp);
     for (unsigned int i = 0; i < o2::tpc::GEMSTACKS; ++i) {
       pc.outputs().snapshot(Output{gDataOriginTPC, mDataDescrOut[mCurrentOutLane], header::DataHeader::SubSpecificationType{i}}, mSACs[i]);
     }

Detectors/TPC/workflow/src/OccupancyFilterSpec.cxx

@@ -106,7 +106,7 @@ class OccupancyFilterDevice : public o2::framework::Task
   {
     o2::tpc::TPCSectorHeader header{sector};
     header.activeSectors = (0x1 << sector);
-    output.snapshot(Output{gDataOriginTPC, "FILTERDIG", static_cast<SubSpecificationType>(sector), Lifetime::Sporadic, header}, digits);
+    output.snapshot(Output{gDataOriginTPC, "FILTERDIG", static_cast<SubSpecificationType>(sector), header}, digits);
   }
 };
 

Detectors/TPC/workflow/src/TPCVDriftTglCalibSpec.cxx

@@ -104,8 +104,8 @@ void TPCVDriftTglCalibSpec::sendOutput(DataAllocator& output)
     auto image = o2::ccdb::CcdbApi::createObjectImage(&payloadVec[i], &w);
     LOG(info) << "Sending object " << w.getPath() << "/" << w.getFileName() << " of size " << image->size()
               << " bytes, valid for " << w.getStartValidityTimestamp() << " : " << w.getEndValidityTimestamp();
-    output.snapshot(Output{o2::calibration::Utils::gDataOriginCDBPayload, "TPCVDTGL", i, Lifetime::Sporadic}, *image.get()); // vector<char>
-    output.snapshot(Output{o2::calibration::Utils::gDataOriginCDBWrapper, "TPCVDTGL", i, Lifetime::Sporadic}, w);            // root-serialized
+    output.snapshot(Output{o2::calibration::Utils::gDataOriginCDBPayload, "TPCVDTGL", i}, *image.get()); // vector<char>
+    output.snapshot(Output{o2::calibration::Utils::gDataOriginCDBWrapper, "TPCVDTGL", i}, w);            // root-serialized
   }
   if (payloadVec.size()) {
     mCalibrator->initOutput(); // reset the outputs once they are already sent

Detectors/ZDC/calib/src/BaselineCalibEPNSpec.cxx

@@ -127,7 +127,7 @@ void BaselineCalibEPNSpec::run(ProcessingContext& pc)
     }
     // Send intermediate calibration data
     auto& summary = mWorker.mData.getSummary();
-    o2::framework::Output outputData("ZDC", "BASECALIBDATA", 0, Lifetime::Sporadic);
+    o2::framework::Output outputData("ZDC", "BASECALIBDATA", 0);
     pc.outputs().snapshot(outputData, summary);
     if (pc.transitionState() == TransitionHandlingState::Requested) {
       // End of processing for this run

Detectors/ZDC/calib/src/NoiseCalibEPNSpec.cxx

@@ -113,19 +113,19 @@ void NoiseCalibEPNSpec::run(ProcessingContext& pc)
     if (mVerbosity > DbgMedium && mModTF > 0) {
       LOG(info) << "Send intermediate calibration data mProcessed=" << mProcessed << " >= mModTF=" << mModTF;
     }
-    o2::framework::Output outputData("ZDC", "NOISECALIBDATA", 0, Lifetime::Sporadic);
+    o2::framework::Output outputData("ZDC", "NOISECALIBDATA", 0);
     pc.outputs().snapshot(outputData, summary);
     for (int ih = 0; ih < NChannels; ih++) {
       {
-        o2::framework::Output output("ZDC", "NOISE_1DH", ih, Lifetime::Sporadic);
+        o2::framework::Output output("ZDC", "NOISE_1DH", ih);
         pc.outputs().snapshot(output, mWorker.mH[0][ih]->getBase());
       }
       {
-        o2::framework::Output output("ZDC", "NOISE_1DH_S", ih, Lifetime::Sporadic);
+        o2::framework::Output output("ZDC", "NOISE_1DH_S", ih);
         pc.outputs().snapshot(output, mWorker.mH[1][ih]->getBase());
       }
       {
-        o2::framework::Output output("ZDC", "NOISE_1DH_D", ih, Lifetime::Sporadic);
+        o2::framework::Output output("ZDC", "NOISE_1DH_D", ih);
         pc.outputs().snapshot(output, mWorker.mH[2][ih]->getBase());
       }
     }