Skip to content

Commit 2606e4a

Browse files
ktfdavidrohr
authored andcommitted
DPL: print missing data when dropping timeframes
1 parent 27eb1a3 commit 2606e4a

File tree

1 file changed

+12
-0
lines changed

1 file changed

+12
-0
lines changed

Framework/Core/src/DataRelayer.cxx

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -297,11 +297,13 @@ void DataRelayer::setOldestPossibleInput(TimesliceId proposed, ChannelIndex chan
297297
continue;
298298
}
299299
mPruneOps.push_back(PruneOp{si});
300+
bool didDrop = false;
300301
for (size_t mi = 0; mi < mInputs.size(); ++mi) {
301302
auto& input = mInputs[mi];
302303
auto& element = mCache[si * mInputs.size() + mi];
303304
if (element.size() != 0) {
304305
if (input.lifetime != Lifetime::Condition && mCompletionPolicy.name != "internal-dpl-injected-dummy-sink") {
306+
didDrop = true;
305307
LOGP(error, "Dropping incomplete {} Lifetime::{} data in slot {} with timestamp {} < {} as it can never be completed.", DataSpecUtils::describe(input), input.lifetime, si, timestamp.value, newOldest.timeslice.value);
306308
} else {
307309
LOGP(debug,
@@ -312,6 +314,16 @@ void DataRelayer::setOldestPossibleInput(TimesliceId proposed, ChannelIndex chan
312314
}
313315
}
314316
}
317+
// We did drop some data. Let's print what was missing.
318+
if (didDrop) {
319+
for (size_t mi = 0; mi < mInputs.size(); ++mi) {
320+
auto& input = mInputs[mi];
321+
auto& element = mCache[si * mInputs.size() + mi];
322+
if (element.size() == 0) {
323+
LOGP(error, "Missing {} (lifetime:{}) while dropping incomplete data in slot {} with timestamp {} < {}.", DataSpecUtils::describe(input), input.lifetime, si, timestamp.value, newOldest.timeslice.value);
324+
}
325+
}
326+
}
315327
}
316328
}
317329

0 commit comments

Comments
 (0)