changed Location parameter to reference

Author: jmyrcha

EventVisualisation/DataConverter/include/EventVisualisationDataConverter/VisualisationEventJSONSerializer.h

@@ -56,7 +56,7 @@ class VisualisationEventJSONSerializer : public VisualisationEventSerializer
 
  public:
   bool fromFile(VisualisationEvent& event, std::string fileName) override;
-  void toFile(const VisualisationEvent& event, Location location) override;
+  void toFile(const VisualisationEvent& event, Location& location) override;
   ~VisualisationEventJSONSerializer() override = default;
 };
 

EventVisualisation/DataConverter/include/EventVisualisationDataConverter/VisualisationEventOpenGLSerializer.h

@@ -38,7 +38,7 @@ class VisualisationEventOpenGLSerializer : public VisualisationEventSerializer
  public:
   const std::string serializerName() const override { return std::string("VisualisationEventOpenGLSerializer"); }
   bool fromFile(VisualisationEvent& event, std::string fileName) override;
-  void toFile(const VisualisationEvent& event, Location location) override;
+  void toFile(const VisualisationEvent& event, Location& location) override;
   ~VisualisationEventOpenGLSerializer() override = default;
 };
 

EventVisualisation/DataConverter/include/EventVisualisationDataConverter/VisualisationEventROOTSerializer.h

@@ -44,7 +44,7 @@ class VisualisationEventROOTSerializer : public VisualisationEventSerializer
  public:
   [[nodiscard]] const std::string serializerName() const override { return std::string("VisualisationEventROOTSerializer"); }
   bool fromFile(VisualisationEvent& event, std::string fileName) override;
-  void toFile(const VisualisationEvent& event, Location location) override;
+  void toFile(const VisualisationEvent& event, Location& location) override;
   ~VisualisationEventROOTSerializer() override = default;
 };
 

EventVisualisation/DataConverter/include/EventVisualisationDataConverter/VisualisationEventSerializer.h

@@ -46,7 +46,7 @@ class VisualisationEventSerializer
   static o2::dataformats::GlobalTrackID deserialize(unsigned source, unsigned index, unsigned flags);
   static VisualisationEventSerializer* getInstance(std::string ext) { return instances[ext]; }
   virtual bool fromFile(VisualisationEvent& event, std::string fileName) = 0;
-  virtual void toFile(const VisualisationEvent& event, Location location) = 0;
+  virtual void toFile(const VisualisationEvent& event, Location& location) = 0;
   virtual const std::string serializerName() const = 0;
   virtual ~VisualisationEventSerializer() = default;
 };

EventVisualisation/DataConverter/src/VisualisationEventJSONSerializer.cxx

@@ -29,7 +29,7 @@ using namespace rapidjson;
 namespace o2::event_visualisation
 {
 
-void VisualisationEventJSONSerializer::toFile(const VisualisationEvent& event, Location location)
+void VisualisationEventJSONSerializer::toFile(const VisualisationEvent& event, Location& location)
 {
   std::string fileName = location.fileName();
   std::string json = toJson(event);

EventVisualisation/DataConverter/src/VisualisationEventOpenGLSerializer.cxx

@@ -83,7 +83,7 @@ const auto CALT = "CALT"; // calo PID
 
 const auto FINE = "FINE"; //
 
-void VisualisationEventOpenGLSerializer::toFile(const VisualisationEvent& event, Location location)
+void VisualisationEventOpenGLSerializer::toFile(const VisualisationEvent& event, Location& location)
 {
   std::string fileName = location.fileName();
   static const std::vector<std::string> det_coma = {

EventVisualisation/DataConverter/src/VisualisationEventROOTSerializer.cxx

@@ -93,7 +93,7 @@ bool VisualisationEventROOTSerializer::existUInt64(TFile& f, const char* name)
   return true;
 }
 
-void VisualisationEventROOTSerializer::toFile(const VisualisationEvent& event, Location location)
+void VisualisationEventROOTSerializer::toFile(const VisualisationEvent& event, Location& location)
 {
   std::string fileName = location.fileName();
   TFile f(fileName.c_str(), "recreate");

EventVisualisation/DataConverter/src/converter.cxx

@@ -35,7 +35,7 @@
 using namespace std::chrono_literals;
 
 // source file name, destination (not existing) file name, if limit > 0 then limit EACH type of data
-int singleFileConversion(const std::string& src, const o2::event_visualisation::Location& dst, const int limit = -1)
+int singleFileConversion(const std::string& src, o2::event_visualisation::Location& dst, const int limit = -1)
 {
   LOGF(info, "Translate: %s -> %s", src, dst.fileName());
   o2::event_visualisation::VisualisationEvent vEvent;

EventVisualisation/Workflow/src/EveWorkflowHelper.cxx

@@ -523,13 +523,13 @@ void EveWorkflowHelper::save(const std::string& jsonPath, const std::string& ext
   mEvent.setEveVersion(o2_eve_version);
   FileProducer producer(jsonPath, ext);
   producer.reduceNumberOfFiles(numberOfFiles);
-
-  VisualisationEventSerializer::getInstance(ext)->toFile(mEvent, Location({.fileName = producer.newFileName(),
-                                                                           .port = receiverPort,
-                                                                           .timeout = receiverTimeout,
-                                                                           .host = receiverHostname,
-                                                                           .toFile = !useOnlySockets,
-                                                                           .toSocket = !useOnlyFiles}));
+  Location location({.fileName = producer.newFileName(),
+                            .port = receiverPort,
+                            .timeout = receiverTimeout,
+                            .host = receiverHostname,
+                            .toFile = !useOnlySockets,
+                            .toSocket = !useOnlyFiles});
+  VisualisationEventSerializer::getInstance(ext)->toFile(mEvent, location);
 }
 
 std::vector<PNT>