GPU: Remove bogus placement new leading to memory leak

davidrohr · davidrohr · commit 1c4d839ae928 · 2025-03-18T08:15:35.000+01:00
diff --git a/GPU/GPUTracking/Base/GPUReconstruction.cxx b/GPU/GPUTracking/Base/GPUReconstruction.cxx
@@ -86,8 +86,6 @@ GPUReconstruction::GPUReconstruction(const GPUSettingsDeviceBackend& cfg) : mHos
     mMaster = cfg.master;
     cfg.master->mSlaves.emplace_back(this);
   }
-  new (&mProcessingSettings) GPUSettingsProcessing;
-  new (&mGRPSettings) GPUSettingsGRP;
   param().SetDefaults(&mGRPSettings);
   mMemoryScalers.reset(new GPUMemorySizeScalers);
   for (uint32_t i = 0; i < NSECTORS; i++) {
diff --git a/GPU/GPUTracking/Base/GPUReconstructionLibrary.cxx b/GPU/GPUTracking/Base/GPUReconstructionLibrary.cxx
@@ -34,7 +34,6 @@ using namespace o2::gpu;
 GPUReconstruction* GPUReconstruction::CreateInstance(DeviceType type, bool forceType, GPUReconstruction* master)
 {
   GPUSettingsDeviceBackend cfg;
-  new (&cfg) GPUSettingsDeviceBackend;
   cfg.deviceType = type;
   cfg.forceDeviceType = forceType;
   cfg.master = master;
diff --git a/GPU/GPUTracking/Definitions/GPUSettingsList.h b/GPU/GPUTracking/Definitions/GPUSettingsList.h
@@ -607,7 +607,7 @@ EndConfig()
 
 // Derrived parameters used in GPUParam
 BeginHiddenConfig(GPUSettingsParam, param)
-AddVariableRTC(dAlpha, float, 0.f)                 // angular size
+AddVariableRTC(dAlpha, float, 0.f)            // angular size
 AddVariableRTC(assumeConstantBz, int8_t, 0)   // Assume a constant magnetic field
 AddVariableRTC(toyMCEventsFlag, int8_t, 0)    // events were build with home-made event generator
 AddVariableRTC(continuousTracking, int8_t, 0) // Continuous tracking, estimate bz and errors for abs(z) = 125cm during seeding

Original file line number	Diff line number	Diff line change
`@@ -86,8 +86,6 @@ GPUReconstruction::GPUReconstruction(const GPUSettingsDeviceBackend& cfg) : mHos`
`86`	`86`	`mMaster = cfg.master;`
`87`	`87`	`cfg.master->mSlaves.emplace_back(this);`
`88`	`88`	`}`
`89`		`- new (&mProcessingSettings) GPUSettingsProcessing;`
`90`		`- new (&mGRPSettings) GPUSettingsGRP;`
`91`	`89`	`param().SetDefaults(&mGRPSettings);`
`92`	`90`	`mMemoryScalers.reset(new GPUMemorySizeScalers);`
`93`	`91`	`for (uint32_t i = 0; i < NSECTORS; i++) {`
Original file line number	Diff line number	Diff line change
`@@ -34,7 +34,6 @@ using namespace o2::gpu;`
`34`	`34`	`GPUReconstruction* GPUReconstruction::CreateInstance(DeviceType type, bool forceType, GPUReconstruction* master)`
`35`	`35`	`{`
`36`	`36`	`GPUSettingsDeviceBackend cfg;`
`37`		`- new (&cfg) GPUSettingsDeviceBackend;`
`38`	`37`	`cfg.deviceType = type;`
`39`	`38`	`cfg.forceDeviceType = forceType;`
`40`	`39`	`cfg.master = master;`