fix

Author: lietava

DataFormats/Detectors/CTP/include/DataFormatsCTP/Configuration.h

@@ -208,7 +208,7 @@ std::ostream& operator<<(std::ostream& in, const CTPConfiguration& conf);
 struct CtpCfg {
   CtpCfg() = default;
   std::string filename = "ctp.cfg";
-  CtpCfg readAndSave(std::string& path, int& ret);
+  int readAndSave(std::string& path);
   uint32_t TFOrbits = 0;
   int ccdb = -1; // -1 means def constructor was called
   uint32_t orbitShift = 0;

DataFormats/Detectors/CTP/src/Configuration.cxx

@@ -1177,9 +1177,8 @@ int CTPInputsConfiguration::getInputIndexFromName(std::string& name)
   return 0xff;
 }
 
-CtpCfg CtpCfg::readAndSave(std::string& path, int& ret)
+int CtpCfg::readAndSave(std::string& path)
 {
-  ret = 0;
   std::string file = path + filename;
   std::ifstream ctpcfg(file);
   if (ctpcfg.is_open()) {
@@ -1214,9 +1213,9 @@ CtpCfg CtpCfg::readAndSave(std::string& path, int& ret)
     LOG(warn) << "Open file success:" << file;
   } else {
     LOG(warn) << "Can not open file:" << file;
-    ret = 1;
+    return 1;
   }
-  return *this;
+  return 0;
 }
 
 std::ostream& o2::ctp::operator<<(std::ostream& in, const o2::ctp::CTPConfiguration& conf)

Detectors/CTP/workflowScalers/src/ctpCCDBManager.cxx

@@ -174,8 +174,7 @@ int ctpCCDBManager::saveCtpCfg(uint32_t runNumber, long timeStart)
     return 0;
   }
   CtpCfg ctpcfg;
-  int ret;
-  ctpcfg.readAndSave(mCtpCfgDir, ret);
+  int ret = ctpcfg.readAndSave(mCtpCfgDir);
   if (ret == 0) {
     using namespace std::chrono_literals;
     std::chrono::seconds days3 = 259200s;