bug in hillclimbing

papp-pal-andras · papp-pal-andras · commit f51ace799abd · 2026-02-16T12:10:17.000+01:00
diff --git a/include/osp/bsp/scheduler/LocalSearch/HillClimbing/hill_climbing.hpp b/include/osp/bsp/scheduler/LocalSearch/HillClimbing/hill_climbing.hpp
@@ -579,7 +579,7 @@ void HillClimbingScheduler<GraphT>::AddMoveOption(const VertexIdx node, const un
 template <typename GraphT>
 void HillClimbingScheduler<GraphT>::EraseMoveOption(VertexIdx node, unsigned proc, Direction dir) {
     canMove_[dir][node][proc] = false;
-    if (nextMove_.first == dir && nextMove_.second->first == node && nextMove_.second->second == proc) {
+    if (nextMove_.first == dir && nextMove_.second != moveOptions_[dir].end() && nextMove_.second->first == node && nextMove_.second->second == proc) {
         ++nextMove_.second;
     }
     moveOptions_[dir].erase(movePointer_[dir][node][proc]);

Original file line number	Diff line number	Diff line change
`@@ -579,7 +579,7 @@ void HillClimbingScheduler<GraphT>::AddMoveOption(const VertexIdx node, const un`
`579`	`579`	`template <typename GraphT>`
`580`	`580`	`void HillClimbingScheduler<GraphT>::EraseMoveOption(VertexIdx node, unsigned proc, Direction dir) {`
`581`	`581`	`canMove_[dir][node][proc] = false;`
`582`		`- if (nextMove_.first == dir && nextMove_.second->first == node && nextMove_.second->second == proc) {`
	`582`	`+ if (nextMove_.first == dir && nextMove_.second != moveOptions_[dir].end() && nextMove_.second->first == node && nextMove_.second->second == proc) {`
`583`	`583`	`++nextMove_.second;`
`584`	`584`	`}`
`585`	`585`	`moveOptions_[dir].erase(movePointer_[dir][node][proc]);`