Skip to content

swapOwner can fail in CPKFactory #132

@hexyls

Description

@hexyls

If the estimated gas for createProxyAndExecTransaction is too low swapOwner can fail silently during execTransaction to Gnosis Safe v1.2.0 while not rolling back the whole transaction.

Users can potentially lose funds if they transfer assets to the proxy and ownership of the proxy is not successfully assigned to the user.

Transfer of ownership is not verified after the swapOwner call. We should probably check the return value of execTransaction to check if the transaction was successful.

example transaction

Should be considered for #126

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions