Security Review Finding — LOW Priority
Source: Krillnotes Security Review v1.0.1 (April 2026)
Location: krillnotes-core/src/core/invite.rs:180-193
Description
read_json_from_zip_bytes() reads ZIP entries without verifying ZIP integrity (CRC32). Corrupted ZIPs could cause parsing failures with unhelpful error messages.
Impact
Low — signature verification over parsed JSON is the actual security boundary. This is a robustness/UX concern rather than a security vulnerability. Corrupted archives will fail at the JSON parsing or signature verification stage anyway.
Recommendation
Add CRC32 integrity checks when reading ZIP entries for better error messages.
Acceptance Criteria
Security Review Finding — LOW Priority
Source: Krillnotes Security Review v1.0.1 (April 2026)
Location:
krillnotes-core/src/core/invite.rs:180-193Description
read_json_from_zip_bytes()reads ZIP entries without verifying ZIP integrity (CRC32). Corrupted ZIPs could cause parsing failures with unhelpful error messages.Impact
Low — signature verification over parsed JSON is the actual security boundary. This is a robustness/UX concern rather than a security vulnerability. Corrupted archives will fail at the JSON parsing or signature verification stage anyway.
Recommendation
Add CRC32 integrity checks when reading ZIP entries for better error messages.
Acceptance Criteria
read_json_from_zip_bytes()