Player instance swap incompatible with grim

[runningbird2]

survival-1  | net.minecraft.class_148: Ticking player
survival-1  | 	at knot//net.minecraft.class_3222.method_14226(class_3222.java:793)
survival-1  | 	at knot//net.minecraft.class_3244.method_73086(class_3244.java:322)
survival-1  | 	at knot//net.minecraft.class_3244.method_18784(class_3244.java:299)
survival-1  | 	at knot//net.minecraft.class_2535.method_10754(class_2535.java:369)
survival-1  | 	at knot//net.minecraft.class_3242.method_14357(class_3242.java:149)
survival-1  | 	at knot//net.minecraft.server.MinecraftServer.method_61254(MinecraftServer.java:1187)
survival-1  | 	at knot//net.minecraft.class_3176.method_61254(class_3176.java:438)
survival-1  | 	at knot//net.minecraft.server.MinecraftServer.method_3813(MinecraftServer.java:1156)
survival-1  | 	at knot//net.minecraft.server.MinecraftServer.method_3748(MinecraftServer.java:1016)
survival-1  | 	at knot//net.minecraft.class_3176.method_3748(class_3176.java:318)
survival-1  | 	at knot//net.minecraft.server.MinecraftServer.method_76677(MinecraftServer.java:1049)
survival-1  | 	at knot//net.minecraft.server.MinecraftServer.method_29741(MinecraftServer.java:771)
survival-1  | 	at knot//net.minecraft.server.MinecraftServer.method_29739(MinecraftServer.java:301)
survival-1  | 	at java.base/java.lang.Thread.run(Unknown Source)
survival-1  | Caused by: java.lang.IllegalStateException: Player swapping is already happening!
survival-1  | 	at knot//net.minecraft.class_3324.worldthreader$swapRemovedPlayerWithNewCopy(class_3324.java:9967)
survival-1  | 	at knot//net.minecraft.class_3244.worldthreader$swapRemovedPlayerWithNewCopy(class_3244.java:19376)
survival-1  | 	at knot//net.minecraft.class_3222.handler$fdl000$worldthreader$swapPlayerWithNewInstance(class_3222.java:18505)
survival-1  | 	at knot//net.minecraft.class_3222.method_61275(class_3222.java:1198)
survival-1  | 	at knot//net.minecraft.class_3222.method_5731(class_3222.java:210)
survival-1  | 	at knot//net.minecraft.class_1297.method_60698(class_1297.java:2816)
survival-1  | 	at knot//net.minecraft.class_1297.method_5670(class_1297.java:581)
survival-1  | 	at knot//net.minecraft.class_1309.method_5670(class_1309.java:428)
survival-1  | 	at knot//net.minecraft.class_1297.method_5773(class_1297.java:562)
survival-1  | 	at knot//net.minecraft.class_1309.method_5773(class_1309.java:2779)
survival-1  | 	at knot//net.minecraft.class_1657.method_5773(class_1657.java:288)
survival-1  | 	at knot//net.minecraft.class_3222.method_14226(class_3222.java:715)
survival-1  | 	... 13 more

Unclear what causes this but portals seem to break when this error occurs.

[2No2Name]

The issue seems to be caused by another issue, so without more information I cannot do anything more than the above commit

[runningbird2]

Still investigating this, thanks for the quick update. Looks like this is not a world threader issue but an issue with grim? Apologies the original error was truncated. full error: https://mclo.gs/lHgbdbx

[2No2Name]

I don't think I can fix this on worldthreader's side. If grim authors want to support this mod, they probably have to fix it on their side

[runningbird2]

Sounds good, A question for you in GrimAnticheat/Grim#2509.

[2No2Name]

The relevant code seems to be here

https://github.com/GrimAnticheat/Grim/blob/4ca65b1670b01efff29ba1d1e491d67c8862a2eb/fabric/src/main/java/ac/grim/grimac/platform/fabric/mixins/ServerPlayerMixin.java#L12

[2No2Name]

There have been more comments here
GrimAnticheat/Grim#2509 (comment)