Fix Song Loading Issues#89
Open
eamuse wants to merge 2 commits into
Open
Conversation
Fixed issues when unlock all is disabled and cleaned up importing songs.
Author
|
Updated this to be in sync with recent commits. |
- Further cleaned up common.ts, added logic to lock valk songs on F-spec EG. - Removed Puni Puni Parade from LICENSED_SONGS6 and added it to VALKYRIE_SONGS alongside VALKYRIE ASSAULT. These songs no longer show up on F-spec.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed #88 and cleaned up the code used for song importing in common.ts. The issue was caused by songs removed before SDVX6 not having a
"distribution_date"key. Added a check to skip songs without this key added for SDVX6+.Tested on versions KFC-2026051200 (SDVX7) and KFC-2025120900 (SDVX6) and unlocks worked as expected both on and off.