Skip to content

Feedback #1

@VojtechVitek

Description

@VojtechVitek

I really like this pkg so far.

Some feedback/ideas, as I'm testing it out:

  • hadle panic & report it as last_error (rethrow panic or provide onPanic hook?)
  • on error, I see "last_error": null in stats
  • Add runnable.Must(), which would bring down the whole group on error (e.g. HTTP server)
  • improve docs around runnable.Retry() -- it's not very clear what the resetAfter arg is for
  • add uptime time.Duration to Status
  • run.New() return *struct instead of an interface
  • run.Group() return *struct instead of an interface

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions