You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
#2095 had various comments after upgrading the protocol to version 0.15. #2132 addresses all of them, except for these remaining ones:
conv.rs dedup: de-duplicate the conversion helpers shared between conv.rs and conv.rs, and rename the module to conversions.rs. (link)
details_commitment design question: do we still need details_commitment, or can we drop the column? Investigate how we use it and potentially remove it. (link) <- ended up being addressed in fix: #2095 follow-ups #2132
get_account() is expensive: get_account() deserializes the full Account on every partial delta; switch to applying updates instead of loading the whole account each time. (link)
helpers.rs explanation: add comments explaining why these helpers live here instead of upstream. (link)
#2095 had various comments after upgrading the protocol to version 0.15. #2132 addresses all of them, except for these remaining ones:
conv.rsdedup: de-duplicate the conversion helpers shared betweenconv.rsandconv.rs, and rename the module toconversions.rs. (link)<- ended up being addressed in fix: #2095 follow-ups #2132details_commitmentdesign question: do we still needdetails_commitment, or can we drop the column? Investigate how we use it and potentially remove it. (link)get_account()is expensive:get_account()deserializes the fullAccounton every partial delta; switch to applying updates instead of loading the whole account each time. (link)helpers.rsexplanation: add comments explaining why these helpers live here instead of upstream. (link)Felt::new_uncheckedsafety:Felt::new_unchecked/Word::uncheckedare used withRng. Already tracked upstream incrypto#1025. linkRelated upstream tracking issue: Implement
RandomCoinseeding fromrand::rngcrypto#1025Some of these may require their own issue/discussion, but for now I'm writing them here to have the backlog up to date